Skip to content

Fix comment in RemovePodSandbox#4625

Merged
estesp merged 1 commit intocontainerd:masterfrom
dcantah:fix-removesandbox-comment
Oct 13, 2020
Merged

Fix comment in RemovePodSandbox#4625
estesp merged 1 commit intocontainerd:masterfrom
dcantah:fix-removesandbox-comment

Conversation

@dcantah
Copy link
Copy Markdown
Member

@dcantah dcantah commented Oct 13, 2020

Signed-off-by: Daniel Canter [email protected]

Signed-off-by: Daniel Canter <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

Hi @dcantah. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Oct 13, 2020

Build succeeded.

@dcantah
Copy link
Copy Markdown
Member Author

dcantah commented Oct 13, 2020

@estesp @mikebrow

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit e4e05c6 into containerd:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants