Skip to content

fix no-pivot not working in io.containerd.runtime.v1.linux#4621

Merged
estesp merged 1 commit intocontainerd:masterfrom
Zhang-Jianming:no-pivot-not-working
Oct 12, 2020
Merged

fix no-pivot not working in io.containerd.runtime.v1.linux#4621
estesp merged 1 commit intocontainerd:masterfrom
Zhang-Jianming:no-pivot-not-working

Conversation

@Zhang-Jianming
Copy link
Copy Markdown

@Zhang-Jianming Zhang-Jianming commented Oct 12, 2020

no_pivot not working in io.containerd.runtime.v1.linux

relates to 1582

Signed-off-by: zhangjianming [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Oct 12, 2020

Hi @Zhang-Jianming. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Oct 12, 2020

Build succeeded.

@Zhang-Jianming
Copy link
Copy Markdown
Author

Zhang-Jianming commented Oct 12, 2020

@mikebrow @AkihiroSuda PTAL,Thanks.

Zyqsempai
Zyqsempai approved these changes Oct 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

estesp
estesp approved these changes Oct 12, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit cd2d351 into containerd:master Oct 12, 2020
mikebrow
mikebrow reviewed Oct 12, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikebrow mikebrow mikebrow left review comments

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

+1 more reviewer

@Zyqsempai Zyqsempai Zyqsempai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Zhang-Jianming @k8s-ci-robot @estesp @Zyqsempai @AkihiroSuda @mikebrow