Move proto format ci check to proto job#4611
Merged
fuweid merged 1 commit intocontainerd:masterfrom Oct 8, 2020
Merged
Conversation
dmcgowan
force-pushed
the
move-proto-fmt-ci
branch
from
0b5a408 to
2e6d7b9
Compare
|
Build succeeded.
|
mxpv
reviewed
Oct 8, 2020
Member
There was a problem hiding this comment.
We already update PATH in Set env step above:
https://github.com/containerd/containerd/pull/4611/files#diff-e9f950f17198d3d5e3122a44230a09b9R137
I think this line should not be needed.
Member
Author
There was a problem hiding this comment.
Removed, let's see what ci says :)
Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
move-proto-fmt-ci
branch
from
2e6d7b9 to
8b20ca9
Compare
|
Build succeeded.
|
austinvazquez
added a commit
to austinvazquez/containerd
that referenced
this pull request
Feb 14, 2025
This is the fifth patch release in the 1.2.z series of runc. It primarily fixes an issue caused by an upstream systemd bug. There was a regression in systemd v230 which made the way we define device rule restrictions require a systemctl daemon-reload for our transient units. This caused issues for workloads using NVIDIA GPUs. Workaround the upstream regression by re-arranging how the unit properties are defined. (containerd#4568, containerd#4612, containerd#4615) Dependency github.com/cyphar/filepath-securejoin is updated to v0.4.1, to allow projects that vendor runc to bump it as well. (containerd#4608) CI: fixed criu-dev compilation. (containerd#4611) Dependency golang.org/x/net is updated to 0.33.0. (containerd#4632) diff: opencontainers/[email protected] Signed-off-by: Austin Vazquez <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to lint change