Enable linter checks on Windows#4609
Merged
dmcgowan merged 3 commits intocontainerd:masterfrom Oct 8, 2020
Merged
Conversation
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
mxpv
force-pushed
the
linter
branch
2 times, most recently
from
de62f92 to
1850510
Compare
Signed-off-by: Maksym Pavlenko <[email protected]>
Member
|
After this change we should probably add |
costanic
added a commit
to PelionIoT/snap-pelion-edge
that referenced
this pull request
Jan 7, 2021
Use source-tag attribute instead of source-commit attribute in
order to clone the repo in a single step, rather than a two-step
process of git-clone followed by git-checkout <sha>, which due
to a setting in the .gitattributes file of the docker-containerd
repo leaves the freshly cloned repo in a dirty state and thus
unable to checkout a specific SHA.
Here is the PR that introduced the build breakage:
containerd/containerd#4609
Specifically this commit:
containerd/containerd@8b03df2
For reference regarding the “eol” setting in .gitattributes file:
https://www.git-scm.com/docs/gitattributes#_eol
“Note that setting this attribute on paths which are in the
index with CRLF line endings may make the paths to be
considered dirty”
costanic
added a commit
to PelionIoT/snap-pelion-edge
that referenced
this pull request
Jan 8, 2021
Use source-tag attribute instead of source-commit attribute in
order to clone the repo in a single step, rather than a two-step
process of git-clone followed by git-checkout <sha>, which due
to a setting in the .gitattributes file of the docker-containerd
repo leaves the freshly cloned repo in a dirty state and thus
unable to checkout a specific SHA.
Here is the PR that introduced the build breakage:
containerd/containerd#4609
Specifically this commit:
containerd/containerd@8b03df2
For reference regarding the “eol” setting in .gitattributes file:
https://www.git-scm.com/docs/gitattributes#_eol
“Note that setting this attribute on paths which are in the
index with CRLF line endings may make the paths to be
considered dirty”
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
This will also make linter errors more expressive:
