Skip to content

Refactor CRI related packages#4608

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
mxpv:refactor
Oct 8, 2020
Merged

Refactor CRI related packages#4608
dmcgowan merged 1 commit intocontainerd:masterfrom
mxpv:refactor

Conversation

@mxpv
Copy link
Copy Markdown
Member

@mxpv mxpv commented Oct 7, 2020

Move pkg/annotations, pkg/constants, pkg/streaming under pkg/cri since these are CRI specific sub-packages.

Signed-off-by: Maksym Pavlenko [email protected]

@mxpv mxpv force-pushed the refactor branch 2 times, most recently from bae22f8 to 40e0825 Compare October 7, 2020 21:30
Signed-off-by: Maksym Pavlenko <[email protected]>
@containerd containerd deleted a comment from theopenlab-ci Bot Oct 7, 2020
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@containerd containerd deleted a comment from theopenlab-ci Bot Oct 7, 2020
@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Oct 7, 2020

/test

@k8s-ci-robot
Copy link
Copy Markdown

@mikebrow: The /test command needs one or more targets.
The following commands are available to trigger jobs:

  • /test pull-containerd-build
  • /test pull-containerd-node-e2e
  • /test pull-containerd-verify
Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Oct 7, 2020

/test pull-containerd-build

Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 822ce4e into containerd:master Oct 8, 2020
austinvazquez added a commit to austinvazquez/containerd that referenced this pull request Feb 14, 2025
This is the fifth patch release in the 1.2.z series of runc. It
primarily fixes an issue caused by an upstream systemd bug.

There was a regression in systemd v230 which made the way we define device
rule restrictions require a systemctl daemon-reload for our transient
units. This caused issues for workloads using NVIDIA GPUs. Workaround the
upstream regression by re-arranging how the unit properties are defined.
(containerd#4568, containerd#4612, containerd#4615)
Dependency github.com/cyphar/filepath-securejoin is updated to v0.4.1,
to allow projects that vendor runc to bump it as well. (containerd#4608)
CI: fixed criu-dev compilation. (containerd#4611)
Dependency golang.org/x/net is updated to 0.33.0. (containerd#4632)

diff: opencontainers/[email protected]

Signed-off-by: Austin Vazquez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants