Skip to content

[release/1.4] cherry-pick: Windows CNI install script using lowercase "destdir"#4601

Merged
dmcgowan merged 1 commit intocontainerd:release/1.4from
estesp:cp-wincni-script
Oct 5, 2020
Merged

[release/1.4] cherry-pick: Windows CNI install script using lowercase "destdir"#4601
dmcgowan merged 1 commit intocontainerd:release/1.4from
estesp:cp-wincni-script

Conversation

@estesp
Copy link
Copy Markdown
Member

@estesp estesp commented Oct 5, 2020

Fixes packaging via GH Actions script, which sets DESTDIR and is used
across many scripts.

Cherry picking #4599

Signed-off-by: Phil Estes [email protected]
(cherry picked from commit 615af42)

Fixes packaging via GH Actions script, which sets DESTDIR and is used
across many scripts.

Signed-off-by: Phil Estes <[email protected]>
(cherry picked from commit 615af42)
@estesp estesp changed the title Windows CNI install script using lowercase "destdir" [release/1.4] cherry-pick: Windows CNI install script using lowercase "destdir" Oct 5, 2020
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Oct 5, 2020

Build succeeded.

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Oct 5, 2020

Is there a test run of this on the 1.4 branch?

@estesp
Copy link
Copy Markdown
Member Author

estesp commented Oct 5, 2020

Will run a test now

@estesp
Copy link
Copy Markdown
Member Author

estesp commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit e44e8eb into containerd:release/1.4 Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants