Allow to use repository scope helper function from other packages#4600
Allow to use repository scope helper function from other packages#4600mxpv merged 1 commit intocontainerd:masterfrom
Conversation
|
Hi @ktock. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
mikebrow
left a comment
mikebrow
left a comment
There was a problem hiding this comment.
Suggestion.. go ahead and make the two contextWith*RepositoryScope functions public scope as well.
`docker.Authorizer` requires library clients to configure scope via context. It is helpful for the clients to use the helper (currently private) functions for generating scope string and to use that function with the combination of other scope-related ones (e.g. `docker.WithScope`). Signed-off-by: Kohei Tokunaga <[email protected]>
|
@mikebrow |
|
Build succeeded.
|
|
/ok-to-test |
7 participants
docker.Authorizerrequires library clients to configure scope via context.It is helpful for the clients to use the helper (currently private) function for
generating scope string and to use that function with the combination of other
scope-related ones (e.g.
docker.WithScope).