Skip to content

[release/1.3] backport CRI release process via GitHub Actions#4598

Merged
estesp merged 60 commits intocontainerd:release/1.3from
estesp:release-script-updates
Oct 5, 2020
Merged

[release/1.3] backport CRI release process via GitHub Actions#4598
estesp merged 60 commits intocontainerd:release/1.3from
estesp:release-script-updates

Conversation

@estesp
Copy link
Copy Markdown
Member

@estesp estesp commented Oct 1, 2020

This is a cherry-pick of all commits from #4465. Only the release.yml commit needed backporting because release/1.3 still requires the seccomp dependency to be installed, unlike the 1.4 branch.

Still need to test and validate this produces the right tarball(s) before we merge.

Random-Liu and others added 30 commits October 1, 2020 16:36
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu and others added 16 commits October 1, 2020 16:51
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Synchronizes unit file with CRI's version

Signed-off-by: Derek McGowan <[email protected]>
Add installation scripts needed to generate CRI + CNI tar package on
release.
Update Github action release script to generate CRI release tarballs for
Linux and Windows.

Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
@thaJeztah
Copy link
Copy Markdown
Member

didn't use -x for the cherry-picks 🙊 🙈

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Oct 1, 2020

Build succeeded.

@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Oct 1, 2020

have to remember that -x trick next time :)

@estesp estesp closed this Oct 2, 2020
@estesp estesp reopened this Oct 2, 2020
@estesp estesp force-pushed the release-script-updates branch from c4ba925 to 4bb1ec0 Compare October 2, 2020 20:26
@estesp
Copy link
Copy Markdown
Member Author

estesp commented Oct 2, 2020

Should be ready for review; tested a release of v1.3.x in my fork: https://github.com/estesp/containerd/actions/runs/284904252

I scripted the cherry pick to pull from the origin's fork so I wouldn't have to manually do almost 60 commits and forgot the -x @thaJeztah. I will do better next time. I feel less inclined to redo because this is mostly about preserving history from another repo, not really connecting patches across releases. The end result is basically copying in files that existing somewhere else. Excuses, excuses, I know :)

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Oct 2, 2020

Build succeeded.

@thaJeztah
Copy link
Copy Markdown
Member

I feel less inclined to redo because this is mostly about preserving history from another repo, not really connecting patches across releases

Definitely not a blocker for these; its just "test" code, and should be easy enough to find back for this file.

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if all testing with this was successful 👍

Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 53371c8 into containerd:release/1.3 Oct 5, 2020
@estesp estesp deleted the release-script-updates branch October 5, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants