Update BUILDING.md - add dependency libseccomp-dev#4597
Update BUILDING.md - add dependency libseccomp-dev#4597AkihiroSuda merged 1 commit intocontainerd:masterfrom
Conversation
|
Hi @mc256. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
AkihiroSuda
left a comment
There was a problem hiding this comment.
The dependency is for runc, not for containerd.
If we want this, this should be written in the Build runc section
|
Build succeeded.
|
|
Build succeeded.
|
estesp
left a comment
There was a problem hiding this comment.
You need to squash the 4 commits into one that has a simple commit message describing the change and has the full Signed-off-by: (3 of your 4 commits do have a proper signature).
I got these errors when I try to build containerd: ``` go build "-mod=vendor" "-buildmode=pie" -tags "seccomp selinux apparmor" -ldflags "-X main.gitCommit="a220b9c6cc100f71ddc67152a12fc04622313dca" -X main.version=1.0.0-rc92+dev " -o runc . Package libseccomp was not found in the pkg-config search path. Perhaps you should add the directory containing `libseccomp.pc' to the PKG_CONFIG_PATH environment variable No package 'libseccomp' found Package libseccomp was not found in the pkg-config search path. Perhaps you should add the directory containing `libseccomp.pc' to the PKG_CONFIG_PATH environment variable No package 'libseccomp' found pkg-config: exit status 1 ``` Solved this problem by installing one extra dependency `libseccomp-dev`. I am using Ubuntu 20.04 and everything works well! See also: opencontainers/runc#1032 Signed-off-by: Jun Lin Chen <[email protected]>
|
Build succeeded.
|
I got these errors when I try to build containerd:
Solved this problem by installing one extra dependency
libseccomp-dev. I am using Ubuntu 20.04 and everything works well!See also: opencontainers/runc#1032
Signed-off-by: Jun Lin Chen [email protected]