mount.isFUSE(): remove unused error return, and extract FUSE unmount to a function#4588
Merged
dmcgowan merged 2 commits intocontainerd:masterfrom Oct 8, 2020
Merged
Conversation
Member
Author
|
@AkihiroSuda ptal |
|
Build succeeded.
|
thaJeztah
force-pushed
the
remove_redundant_error
branch
from
316d9fa to
6081ba7
Compare
thaJeztah
changed the title
|
Build succeeded.
|
AkihiroSuda
reviewed
Sep 28, 2020
dims
reviewed
Sep 28, 2020
The error itself was unused, so may as well remove it. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_redundant_error
branch
from
6081ba7 to
968a386
Compare
Member
Author
|
@AkihiroSuda updated; I think this is what you meant; ptal |
|
Build succeeded.
|
AkihiroSuda
approved these changes
Sep 29, 2020
thaJeztah
force-pushed
the
remove_redundant_error
branch
2 times, most recently
from
0eb3105 to
9f1356f
Compare
|
Build succeeded.
|
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_redundant_error
branch
from
9f1356f to
48f64a1
Compare
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function was added in #3765; the error itself was unused, so may as well remove it.