Update CRI tests to build and push to gcs#4586
Conversation
|
/test pull-containerd-build |
dmcgowan
force-pushed
the
update-cri-push
branch
from
f7dbbdc to
8f3fb4b
Compare
|
/test pull-containerd-build |
dmcgowan
force-pushed
the
update-cri-push
branch
from
8f3fb4b to
a255f27
Compare
|
/test pull-containerd-build |
|
Build succeeded.
|
dmcgowan
force-pushed
the
update-cri-push
branch
from
a255f27 to
724d59b
Compare
|
/test pull-containerd-build |
|
Build succeeded.
|
|
/test pull-containerd-build |
|
Build succeeded.
|
dmcgowan
force-pushed
the
update-cri-push
branch
from
24bd238 to
e1f0951
Compare
|
/test pull-containerd-build |
|
Build succeeded.
|
This enables to the CRI e2e tests to use the build from a PR Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
update-cri-push
branch
from
e1f0951 to
863377a
Compare
|
/test pull-containerd-build |
|
Build succeeded.
|
Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
update-cri-push
branch
from
863377a to
65df8db
Compare
|
Build succeeded.
|
|
/retest |
|
/test pull-containerd-build |
|
/test pull-containerd-node-e2e |
|
@dmcgowan: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| cri-release: releases/$(CRIRELEASE).tar.gz | ||
| @echo "$(WHALE) $@" | ||
| @cd releases && sha256sum $(CRIRELEASE).tar.gz >$(CRIRELEASE).tar.gz.sha256sum | ||
| @cd releases && sha256sum $(CRIRELEASE).tar.gz >$(CRIRELEASE).tar.gz.sha256sum && ln -sf $(CRIRELEASE).tar.gz cri-containerd.tar.gz |
There was a problem hiding this comment.
the links are needed by existing scripts i presume?
There was a problem hiding this comment.
assuming those scripts do not care about the SHA file
There was a problem hiding this comment.
Right now just uses the symlink to resolve the latest, but I think it makes more sense to sha256 check the actual file rather than the link.
| # make push TARBALL_PREFIX=cri-containerd-cni INCLUDE_CNI=true CUSTOM_CONTAINERD=true | ||
|
|
||
| # Build CRI+CNI release | ||
| make BUILDTAGS="seccomp selinux no_aufs no_btrfs no_devmapper no_zfs" cri-cni-release |
There was a problem hiding this comment.
ah cool. we do no_btrfs here so we don't need to install it above.
| # TARBALL is the tarball name. | ||
| TARBALL=${TARBALL:-"cri-containerd.tar.gz"} | ||
| # LATEST is the name of the latest version file. | ||
| LATEST=${LATEST:-"latest"} |
There was a problem hiding this comment.
do we want the suffix .txt? does it render fine in a browser (not sure if it will make a diff)
There was a problem hiding this comment.
I am not really sure how these files are used, this was one thing I couldn't track down in the existing setups. I am just leaving them alone, but cleaning it up after it is working would be great. It looks like we will have to pull in our own e2e configuration anyway. I'm not sure if we can control the configuration script from this repo though.
|
LGTM @dmcgowan |
|
Merging, the e2e tests aren't expected to pass yet |
4 participants
This enables to the CRI e2e tests to use the build from a PR
WIP: for testing