vendor: containerd/console v1.0.1, golang.org/x/sys 2334cc1a136f0a5b4384f1a27e3634457be08553#4583
Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom Sep 26, 2020
Conversation
full diff: https://github.com/containerd/consolve/compare/v1.0.0...v1.0.1 vendor golang.org/x/sys 2334cc1a136f0a5b4384f1a27e3634457be08553 full diff: golang/sys@ed371f2...2334cc1 - unix: add Darwin support for clonefile syscalls - Adds openat2 for linux openat2 is a new syscall added to Linux 5.6. It provides a superset of openat(2) functionality, extending it with flags telling the kernel how to resolve the paths. For more info, see https://lwn.net/Articles/803237/ NOTE that this is a second attempt to add the call; the previous one (https://golang.org/cl/227280) was reverted (https://golang.org/cl/227846) due to the test case failure on ARM (https://golang.org/issue/38357). This CL has the test case reworked to be less assumptive to the testing environment. In particular, it first tries if the most simplistic openat2() call succeeds, and skips the test otherwise. It is done that way because CI can be under under different kernels and in various envrionments -- in particular, Docker+seccomp can result in EPERM from a system call (which is not expected otherwise). For previous discussions about the test case, see https://golang.org/cl/227865. Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
Build succeeded.
|
AkihiroSuda
approved these changes
Sep 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
full diff: https://github.com/containerd/consolve/compare/v1.0.0...v1.0.1
vendor golang.org/x/sys 2334cc1a136f0a5b4384f1a27e3634457be08553
full diff: golang/sys@ed371f2...2334cc1
unix: add Darwin support for clonefile syscalls
Adds openat2 for linux
openat2 is a new syscall added to Linux 5.6. It provides a superset of
openat(2) functionality, extending it with flags telling the kernel how
to resolve the paths.
For more info, see https://lwn.net/Articles/803237/
NOTE that this is a second attempt to add the call; the previous one
(https://golang.org/cl/227280) was reverted
(https://golang.org/cl/227846) due to the test case failure on ARM
(https://golang.org/issue/38357).
This CL has the test case reworked to be less assumptive to the testing
environment. In particular, it first tries if the most simplistic
openat2() call succeeds, and skips the test otherwise. It is done that
way because CI can be under under different kernels and in various
envrionments -- in particular, Docker+seccomp can result in EPERM from a
system call (which is not expected otherwise).
For previous discussions about the test case, see
https://golang.org/cl/227865.
Signed-off-by: Sebastiaan van Stijn [email protected]