Move CRI release logic to Makefile#4580
Merged
mxpv merged 2 commits intocontainerd:masterfrom Sep 23, 2020
Merged
Conversation
|
Build succeeded.
|
dmcgowan
force-pushed
the
move-release-build-makefile
branch
from
eef2262 to
afcc448
Compare
|
Build succeeded.
|
mikebrow
reviewed
Sep 23, 2020
Member
There was a problem hiding this comment.
any reason to leave just seccomp here?
Member
Author
There was a problem hiding this comment.
seccomp is an environment dependency for build rather than a package which gets built along with the release. It doesn't make sense to have the makefile install this since it may already be installed in the environment in some other way.
dims
reviewed
Sep 23, 2020
Member
Author
There was a problem hiding this comment.
it does, updated to use join to create the output dir
dims
reviewed
Sep 23, 2020
Member
There was a problem hiding this comment.
$(ROOTDIR)_output ? similar to line 125
Member
Author
There was a problem hiding this comment.
Updated here and uses sudo when it exists to remove since it gets created with sudo.
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
move-release-build-makefile
branch
from
afcc448 to
241be70
Compare
|
Build succeeded.
|
Member
|
LGTM thanks @dmcgowan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows building the cri-release package outside of the github action. This is also much simpler than the
cri-releasewhich was recently removed as it uses the locally built binaries and scripts which are now in containerd/containerd.Verified Github release changes at https://github.com/dmcgowan/containerd/runs/1153643111