Skip to content

Separate devmapper plugin#4573

Merged
estesp merged 1 commit intocontainerd:masterfrom
teemuteemu:separate-devmapper-plugin
Sep 18, 2020
Merged

Separate devmapper plugin#4573
estesp merged 1 commit intocontainerd:masterfrom
teemuteemu:separate-devmapper-plugin

Conversation

@teemuteemu
Copy link
Copy Markdown

@teemuteemu teemuteemu commented Sep 18, 2020

Solves devicemapper part of #4513

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Sep 18, 2020

Hi @teemuteemu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 18, 2020

Build succeeded.

@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Sep 18, 2020

Please sign and squash commits

@teemuteemu teemuteemu force-pushed the separate-devmapper-plugin branch from 262cf51 to 71fd68a Compare September 18, 2020 10:02
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 18, 2020

Build succeeded.

estesp
estesp approved these changes Sep 18, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 2575a73 into containerd:master Sep 18, 2020
@thaJeztah thaJeztah mentioned this pull request Sep 18, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@teemuteemu @k8s-ci-robot @AkihiroSuda @estesp