Refractor the script to work in both python2 and python3#4559
Merged
estesp merged 1 commit intocontainerd:masterfrom Sep 12, 2020
Merged
Refractor the script to work in both python2 and python3#4559estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
Contributor
Author
|
This should kubernetes/containerd integration test for COS M85 |
Contributor
Author
Contributor
Author
|
/assign @dims @Random-Liu |
|
Build succeeded.
|
dims
reviewed
Sep 11, 2020
dims
reviewed
Sep 11, 2020
Member
|
@bsdnet one nit! looks good to me otherwise. |
Signed-off-by: Roy Yang <[email protected]>
Contributor
Author
|
Build succeeded.
|
Contributor
|
Looks like it should work, to me, as described in this thread, https://groups.google.com/d/msg/kubernetes-sig-node-test-failures/HuAOqZgXMD4/Fe7NBq-ZAwAJ |
Contributor
Author
|
Will this be merged automatically like k8s repo or I need to something @dims @Random-Liu |
Member
Contributor
Author
|
Thanks!
…On Fri, Sep 11, 2020 at 7:39 PM Phil Estes ***@***.***> wrote:
Merged #4559 <#4559> into
master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4559 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBSNJO6IEJLZK7AL7CFVMDSFLNNHANCNFSM4RIH2K6A>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roy Yang [email protected]