Skip to content

fix make test failure of missing sha256 package#4549

Merged
estesp merged 1 commit intocontainerd:masterfrom
ukontainer:fix-missing-sha256
Sep 10, 2020
Merged

fix make test failure of missing sha256 package#4549
estesp merged 1 commit intocontainerd:masterfrom
ukontainer:fix-missing-sha256

Conversation

@thehajime
Copy link
Copy Markdown
Contributor

@thehajime thehajime commented Sep 10, 2020

Looks like since PR #4517 was merged, make test fails, at least on darwin/x86-64, and linux/arm64 (https://logs.openlabtesting.org/logs/26/4526/6bc6efaefef4864a2347f38c642cc24343cfe6d3/check/containerd-build-arm64/85fa8cc/).

error messages is

2020-09-04 01:03:59.591076 | ubuntu-xenial-arm64-openlab | panic: sha256 not available (make sure it is imported) [recovered]
2020-09-04 01:03:59.591113 | ubuntu-xenial-arm64-openlab | 	panic: sha256 not available (make sure it is imported)
2020-09-04 01:03:59.591127 | ubuntu-xenial-arm64-openlab |
2020-09-04 01:03:59.591149 | ubuntu-xenial-arm64-openlab | goroutine 33 [running]:
2020-09-04 01:03:59.591175 | ubuntu-xenial-arm64-openlab | testing.tRunner.func1(0x4000195800)
2020-09-04 01:03:59.591207 | ubuntu-xenial-arm64-openlab | 	/usr/local/go/src/testing/testing.go:874 +0x348
2020-09-04 01:03:59.591231 | ubuntu-xenial-arm64-openlab | panic(0x3c1460, 0x40001c69d0)
2020-09-04 01:03:59.591262 | ubuntu-xenial-arm64-openlab | 	/usr/local/go/src/runtime/panic.go:679 +0x194
2020-09-04 01:03:59.591331 | ubuntu-xenial-arm64-openlab | github.com/containerd/containerd/vendor/github.com/opencontainers/go-digest.Algorithm.Hash(0x4647e2, 0x6, 0x0, 0x40000cde18)
(snip)

Reverting c50ff69 makes this fixed, but this commit contains another workaround.

Fixes: c50ff69 ("refactor(native): separate init from implementation")

Signed-off-by: Hajime Tazaki [email protected]

@thehajime
fix make test failure of missing sha256 package
f4741fb 
Fixes: c50ff69 ("refactor(native): separate init from implementation")

Signed-off-by: Hajime Tazaki <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 10, 2020

Build succeeded.

AkihiroSuda
AkihiroSuda approved these changes Sep 10, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but curious why we didn't catch this in CI?

@estesp
Copy link
Copy Markdown
Member

estesp commented Sep 10, 2020

@AkihiroSuda we don't fail CI for arm64 at this time (the openlab bot just reports it in a comment), and we only lint & build binaries on darwin, so no test runs. A few people did notice (@tianon commented about it somewhere) :) the issue with arm64 but no one had dug into resolving it yet

estesp
estesp approved these changes Sep 10, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianon
Copy link
Copy Markdown
Member

tianon commented Sep 10, 2020

Not a maintainer, but I love seeing the CI passing 😁 (vigorously LGTM 😅)

@estesp estesp merged commit 5d7aa0c into containerd:master Sep 10, 2020
@thehajime thehajime deleted the fix-missing-sha256 branch September 10, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thehajime @estesp @tianon @AkihiroSuda