ctr: Return error if task.Metrics fails#4548
Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom Sep 10, 2020
Merged
Conversation
Signed-off-by: Li Yuxuan <[email protected]>
|
Build succeeded.
|
thaJeztah
approved these changes
Sep 10, 2020
| metric, err := task.Metrics(ctx) | ||
| if err != nil { | ||
| return nil | ||
| return err |
Member
There was a problem hiding this comment.
Looks like this was added in #2504
@samuelkarp I don't see a mention in that PR of this being done on purpose, so I assume it's ok to change.
Member
There was a problem hiding this comment.
I think I probably did this because sometimes I saw a task with no metrics? But all of ctr is effectively sample/debugging code, so I see no issue with making this change.
AkihiroSuda
approved these changes
Sep 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Li Yuxuan [email protected]