Skip to content

Revert "Avoid allocating slice for finding Process" #4545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmcgowan wants to merge 1 commit into from
Closed

Revert "Avoid allocating slice for finding Process" #4545

dmcgowan wants to merge 1 commit into from

Conversation

@dmcgowan
Copy link
Member

@dmcgowan dmcgowan commented Sep 9, 2020

This reverts commit e3ab8bd.

Fixes #4509

I was also able to track down the issue to this commit. This commit is mostly non-functional however it calls the Pid function while still in service lock. The scope of the service lock is only intended to guard access to the service values. In this case the Pid function may acquire a process-level lock, such as for exec processes.

@dmcgowan
Revert "Avoid allocating slice for finding Process"
7ba75db 
This reverts commit e3ab8bd.

Signed-off-by: Derek McGowan <[email protected]>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 9, 2020

Build succeeded.

estesp
estesp approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83
Copy link
Member

cpuguy83 commented Sep 9, 2020

I dove into this quite a bit but have only reproduced it without shim_debug set (so may be it's a separate issue). The issue seems to be related to an unconsumed shim log. The commit added a new log message which gets logged for every exec request from Docker, eventually filling up the fifo. I can unblock it by manually doing tail -f on the log.

On master this is changed from Info to Debug level.

@dmcgowan
Copy link
Member Author

dmcgowan commented Sep 9, 2020

Let's dig into root causing the log angle before merging this one, at least want this ready to go for 1.4.1

@dmcgowan dmcgowan marked this pull request as draft September 9, 2020 23:06
@cpuguy83 cpuguy83 mentioned this pull request Sep 9, 2020
Merged
@dmcgowan dmcgowan deleted the fix-shim-lock-issue-4509 branch March 23, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Containers with curl based health checks becoming unresponsive

4 participants

@dmcgowan @cpuguy83 @estesp @AkihiroSuda