[release/1.3 backport] Fix some signal forwarder issues#4543
Merged
fuweid merged 2 commits intocontainerd:release/1.3from Sep 9, 2020
Merged
Conversation
Previously the signal loop can end up racing with the process exiting. Intead of logging and continuing the loop, exit early. Signed-off-by: Brian Goff <[email protected]> (cherry picked from commit 6650510) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Starting with go1.14, the go runtime hijacks SIGURG but with no way to not send to other signal handlers. In practice, we get this signal frequently. I found this while testing out go1.15 with ctr and multiple execs with only `echo hello`. When the process exits quickly, if the previous commit is not applied, you end up with an error message that it couldn't forward SIGURG to the container (due to the process being gone). Signed-off-by: Brian Goff <[email protected]> (cherry picked from commit 899b4e3) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
@cpuguy83 PTAL |
|
Build succeeded.
|
AkihiroSuda
approved these changes
Sep 8, 2020
zmrow
added a commit
to zmrow/bottlerocket
that referenced
this pull request
Nov 16, 2020
Backport the patch from containerd/containerd#4543 which fixes SIGURG issues with go 1.14+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #4532