Skip to content

zfs: seperate implementation pkg from plugin pkg#4534

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
sedflix:zfs-root-path
Sep 18, 2020
Merged

zfs: seperate implementation pkg from plugin pkg#4534
dmcgowan merged 1 commit intocontainerd:masterfrom
sedflix:zfs-root-path

Conversation

@sedflix
Copy link
Copy Markdown
Contributor

@sedflix sedflix commented Sep 6, 2020

It solves a the zfs part of #4514 and #4513.

containerd/zfs#31 needs to merged along with this.

Signed-off-by: Siddharth Yadav [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 6, 2020

Build succeeded.

@cpuguy83
Copy link
Copy Markdown
Member

[/home/runner/work/containerd/containerd/src/github.com/containerd/containerd/cmd/containerd/builtins_zfs_linux.go:21:10: could not import github.com/containerd/zfs/plugin (cmd/containerd/builtins_zfs_linux.go:21:8: cannot find package \"github.com/containerd/zfs/plugin\" in any 

Forget to git add something?

@sedflix
Copy link
Copy Markdown
Contributor Author

sedflix commented Sep 12, 2020

i don't think so @cpuguy83 ! these test cases should pass once containerd/zfs#31 is merged. working on it.

@cpuguy83
Copy link
Copy Markdown
Member

Oh... I see now. 🤯

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 18, 2020

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants