zfs: seperate implementation pkg from plugin pkg#4534
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Sep 18, 2020
Merged
zfs: seperate implementation pkg from plugin pkg#4534dmcgowan merged 1 commit intocontainerd:masterfrom
dmcgowan merged 1 commit intocontainerd:masterfrom
Conversation
|
Build succeeded.
|
Member
Forget to |
Contributor
Author
|
i don't think so @cpuguy83 ! these test cases should pass once containerd/zfs#31 is merged. working on it. |
Member
|
Oh... I see now. 🤯 |
This was referenced Sep 18, 2020
Signed-off-by: Siddharth Yadav <[email protected]>
6995a26 to
96f4ce4
Compare
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It solves a the zfs part of #4514 and #4513.
containerd/zfs#31 needs to merged along with this.
Signed-off-by: Siddharth Yadav [email protected]