Skip to content

feat(snapshot::aufs): config root_path#4533

Merged
estesp merged 1 commit intocontainerd:masterfrom
sedflix:aufs-seperate-plugin
Sep 18, 2020
Merged

feat(snapshot::aufs): config root_path#4533
estesp merged 1 commit intocontainerd:masterfrom
sedflix:aufs-seperate-plugin

Conversation

@sedflix
Copy link
Copy Markdown
Contributor

@sedflix sedflix commented Sep 6, 2020

It solves the aufs part of the #4514 and #4513 .
containerd/aufs#21 needs to be merged along with this.

Signed-off-by: Siddharth Yadav [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 6, 2020

Build succeeded.

@AkihiroSuda
Copy link
Copy Markdown
Member

Please revendor github.com/containerd/aufs

@sedflix
Copy link
Copy Markdown
Contributor Author

sedflix commented Sep 18, 2020

@AkihiroSuda what do you mean by "revendor github.com/containerd/aufs"?

@thaJeztah
Copy link
Copy Markdown
Member

@sedflix update the commit that's in the vendor.conf file at the root of the repository; https://github.com/containerd/containerd/blob/master/vendor.conf#L106

After that run vndr github.com/containerd/aufs (you can install the vndr tool from https://github.com/LK4D4/vndr)

Running that should fetch the new version of the aufs source code into the vendor directory.

After that, add both vendor.conf and the vendor directory, amend your commit, and force push to update your PR

@thaJeztah
Copy link
Copy Markdown
Member

Latest commit for containerd/aufs looks to be containerd/aufs@dab0cbe

(dab0cbea06f43329c07667afe1a70411ad555a86 )

@sedflix sedflix force-pushed the aufs-seperate-plugin branch from 8691537 to 9848cdd Compare September 18, 2020 13:03
@sedflix sedflix force-pushed the aufs-seperate-plugin branch from 9848cdd to 2354e18 Compare September 18, 2020 13:07
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 18, 2020

Build succeeded.

@sedflix
Copy link
Copy Markdown
Contributor Author

sedflix commented Sep 18, 2020

@thaJeztah thank you so much for the detailed explanation. 😊

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 1484593 into containerd:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants