Skip to content

feat(snapshot::btrfs): config root_path#4518

Merged
dmcgowan merged 2 commits intocontainerd:masterfrom
knight42:feat/btrfs-config-root-path
Sep 3, 2020
Merged

feat(snapshot::btrfs): config root_path#4518
dmcgowan merged 2 commits intocontainerd:masterfrom
knight42:feat/btrfs-config-root-path

Conversation

@knight42
Copy link
Copy Markdown
Contributor

@knight42 knight42 commented Sep 1, 2020

Signed-off-by: knight42 [email protected]

Part of #4513 and #4514

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 1, 2020

Build succeeded.

@knight42 knight42 force-pushed the feat/btrfs-config-root-path branch from 79f1c4f to e8d1124 Compare September 1, 2020 14:46
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 1, 2020

Build succeeded.

@knight42
Copy link
Copy Markdown
Contributor Author

knight42 commented Sep 1, 2020

/cc @AkihiroSuda

@AkihiroSuda
Copy link
Copy Markdown
Member

Looks good but please sign with the real name

@AkihiroSuda
Copy link
Copy Markdown
Member

Also please split commits for #4513 and #4514

@knight42 knight42 force-pushed the feat/btrfs-config-root-path branch from e8d1124 to 3458af8 Compare September 3, 2020 11:46
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 3, 2020

Build succeeded.

@knight42 knight42 force-pushed the feat/btrfs-config-root-path branch from 3458af8 to a52daa2 Compare September 3, 2020 11:54
@knight42
Copy link
Copy Markdown
Contributor Author

knight42 commented Sep 3, 2020

@AkihiroSuda PTAL

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 3, 2020

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit d4e7820 into containerd:master Sep 3, 2020
@knight42 knight42 deleted the feat/btrfs-config-root-path branch September 3, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants