Separate overlay implementation from plugin#4506
Merged
estesp merged 1 commit intocontainerd:masterfrom Aug 27, 2020
Merged
Conversation
Put the overlay plugin in a separate package to allow the overlay package to be used without needing to import and initialize the plugin. Signed-off-by: Derek McGowan <[email protected]>
|
Build succeeded.
|
AkihiroSuda
approved these changes
Aug 27, 2020
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put the overlay plugin in a separate package to allow the overlay package to be used without needing to import and initialize the plugin.
Downstream implementations will need to account for this one, but considering the other plugin refactoring being targeted for 1.5, it makes sense to do it now.