Add configurable overlayfs path#4505
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Aug 27, 2020
Merged
Conversation
|
Build succeeded.
|
ashrayjain
force-pushed
the
aj/configurable-root
branch
2 times, most recently
from
47edab8 to
246c14f
Compare
|
Build succeeded.
|
Member
|
Looks good but needs gofmt |
ashrayjain
force-pushed
the
aj/configurable-root
branch
from
246c14f to
9945b4b
Compare
AkihiroSuda
approved these changes
Aug 26, 2020
This allows configuring the location of the overlayfs snapshotter by
adding the following in config.toml
```
[plugins]
[plugins.overlayfs]
root_path = "/custom_location"
```
This is useful to isolate disk i/o for overlayfs from the rest of
containerd and prevent containers saturating disk i/o from negatively
affecting containerd operations and cause timeouts.
Signed-off-by: Ashray Jain <[email protected]>
ashrayjain
force-pushed
the
aj/configurable-root
branch
from
9945b4b to
5ed177a
Compare
|
Build succeeded.
|
Contributor
Author
|
@AkihiroSuda thanks for the review. is this ready to merge? |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4500
This allows configuring the location of the overlayfs snapshotter by
adding the following in config.toml
This is useful to isolate disk i/o for overlayfs from the rest of
containerd and prevent containers saturating disk i/o from negatively
affecting containerd operations and cause timeouts.