Add logging binary support when terminal is true#4502
Merged
AkihiroSuda merged 3 commits intocontainerd:masterfrom Oct 8, 2020
Merged
Add logging binary support when terminal is true#4502AkihiroSuda merged 3 commits intocontainerd:masterfrom
AkihiroSuda merged 3 commits intocontainerd:masterfrom
Conversation
|
Build succeeded.
|
Currently the shims only support starting the logging binary process if the io.Creator Config does not specify Terminal: true. This means that the program using containerd will only be able to specify FIFO io when Terminal: true, rather than allowing the shim to fork the logging binary process. Hence, containerd consumers face an inconsistent behavior regarding logging binary management depending on the Terminal option. Allowing the shim to fork the logging binary process will introduce consistency between the running container and the logging process. Otherwise, the logging process may die if its parent process dies whereas the container will keep running, resulting in the loss of container logs. Signed-off-by: Akshat Kumar <[email protected]>
|
Build succeeded.
|
AkihiroSuda
reviewed
Aug 26, 2020
| W *os.File | ||
| } | ||
|
|
||
| func NewPipe() (*Pipe, error) { |
Member
There was a problem hiding this comment.
This function and struct don't seem useful. Let's just use os.Pipe
AkihiroSuda
reviewed
Aug 26, 2020
| }, nil | ||
| } | ||
|
|
||
| func NewBinaryCmd(binaryURI *url.URL, id, ns string) *exec.Cmd { |
Signed-off-by: Akshat Kumar <[email protected]>
|
Build succeeded.
|
Member
fuweid
reviewed
Sep 6, 2020
fuweid
reviewed
Sep 6, 2020
akshat-kmr
force-pushed
the
master
branch
2 times, most recently
from
c1c66f0 to
c669e6d
Compare
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
fuweid
reviewed
Sep 10, 2020
akshat-kmr
force-pushed
the
master
branch
2 times, most recently
from
021650c to
5b72445
Compare
|
Build succeeded.
|
Signed-off-by: Akshat Kumar <[email protected]>
|
Build succeeded.
|
Member
|
@cpuguy83 PTAL? |
Author
|
Thanks for the reviews, all. Is this ready to be merged? @AkihiroSuda |
AkihiroSuda
approved these changes
Oct 8, 2020
This was referenced Oct 9, 2020
Member
|
removing the cherry-pick labels for now, per #4616 (comment) and #4615 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the shims only support starting the logging binary process if the
io.Creator Config does not specify Terminal: true. This means that the program
using containerd will only be able to specify FIFO io when Terminal: true,
rather than allowing the shim to fork the logging binary process. Hence,
containerd consumers face an inconsistent behavior regarding logging binary
management depending on the Terminal option.
Allowing the shim to fork the logging binary process will introduce consistency
between the running container and the logging process. Otherwise, the logging
process may die if its parent process dies whereas the container will keep
running, resulting in the loss of container logs.
Signed-off-by: Akshat Kumar [email protected]
Code to start logging binary referenced from pkg/process/io.go