[release/1.3 backport] snapshots/devmapper: fix rollback#4495
Merged
AkihiroSuda merged 1 commit intocontainerd:release/1.3from Aug 24, 2020
Merged
[release/1.3 backport] snapshots/devmapper: fix rollback#4495AkihiroSuda merged 1 commit intocontainerd:release/1.3from
AkihiroSuda merged 1 commit intocontainerd:release/1.3from
Conversation
|
Build succeeded.
|
The rollback mechanism is implemented by calling deleteDevice() and RemoveDevice(). But RemoveDevice() is internally calling deleteDevice() as well. Since a device will be deleted by first deleteDevice(), RemoveDevice() always will see ENODATA. The specific error must be ignored to remove the device's metadata correctly. Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
force-pushed
the
backport-1.3-4437
branch
from
c4bcd4a to
fd6c915
Compare
|
Build succeeded.
|
AkihiroSuda
approved these changes
Aug 24, 2020
kzys
pushed a commit
to kzys/firecracker-containerd
that referenced
this pull request
Aug 25, 2020
kzys
pushed a commit
to kzys/firecracker-containerd
that referenced
this pull request
Aug 25, 2020
The fix is containerd/containerd#4495. Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
pushed a commit
to kzys/firecracker-containerd
that referenced
this pull request
Aug 25, 2020
The fix is containerd/containerd#4495. Signed-off-by: Kazuyoshi Kato <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4437. I will create another backport PR for 1.4 later.
The rollback mechanism is implemented by calling deleteDevice() and
RemoveDevice(). But RemoveDevice() is internally calling
deleteDevice() as well.
Since a device will be deleted by first deleteDevice(),
RemoveDevice() always will see ENODATA. The specific error must be
ignored to remove the device's metadata correctly.
Signed-off-by: Kazuyoshi Kato [email protected]