Skip to content

BUILDING.md: fix description about static builds #4470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fuweid merged 1 commit into from
Aug 23, 2020
Merged

BUILDING.md: fix description about static builds #4470

fuweid merged 1 commit into from
Aug 23, 2020

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Aug 12, 2020 •
edited
Loading

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 12, 2020

Build succeeded.

@AkihiroSuda
BUILDING.md: fix description about static builds
43cbdf8 
* `-linkmode external` is required since Go 1.15 for static builds: golang/go#40711
* Clarify the meaning of "loading plugins"

Signed-off-by: Akihiro Suda <[email protected]>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 12, 2020

Build succeeded.

thaJeztah
thaJeztah approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

thaJeztah commented Aug 12, 2020

Thought the Makefile needed updates as well, but looks like it's not needed, because we're not building with -buildmode pie?

containerd/Makefile

Line 101 in 6988b4d

SHIM_GO_LDFLAGS=-ldflags '-X $(PKG)/version.Version=$(VERSION) -X $(PKG)/version.Revision=$(REVISION) -X $(PKG)/version.Package=$(PACKAGE) -extldflags "-static" $(EXTRA_LDFLAGS)'

containerd/Makefile

Line 195 in 6988b4d

bin/containerd-shim: cmd/containerd-shim FORCE # set !cgo and omit pie for a static shim build: https://github.com/golang/go/issues/17789#issuecomment-258542220

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Aug 12, 2020

@thaJeztah Could you try updating Makefile in Go 1.15 PR? #4050

@thaJeztah
Copy link
Member

thaJeztah commented Aug 12, 2020

@AkihiroSuda to enable -buildmode pie ? Or only to add -linkmode external ?

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Aug 12, 2020

Both (or nothing if not really needed)

@thaJeztah
Copy link
Member

thaJeztah commented Aug 12, 2020

Looks like the Makefile explicitly disables -buildmode pie and CGO for the shims (per golang/go#17789 (comment)), so if the problem only is when building with -buildmode pie, then I think no change is needed

estesp
estesp approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fuweid
fuweid approved these changes Aug 23, 2020
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit c8523cc into containerd:master Aug 23, 2020
@thaJeztah thaJeztah mentioned this pull request Sep 11, 2020
Merged
@estesp estesp added cherry-picked/1.4.x PR commits are cherry picked into the release/1.4 branch and removed cherry-pick/1.4.x labels Sep 11, 2020
@thaJeztah thaJeztah mentioned this pull request Aug 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@fuweid fuweid fuweid approved these changes

Assignees

No one assigned

Labels

cherry-picked/1.4.x PR commits are cherry picked into the release/1.4 branch kind/docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AkihiroSuda @thaJeztah @estesp @fuweid