GitHub actions release of CRI tarball#4465
Merged
estesp merged 59 commits intocontainerd:masterfrom Aug 11, 2020
Merged
Conversation
Member
dmcgowan
commented
Aug 10, 2020
dmcgowan
commented
- Migrates cluster configuration history from CRI repo
- Update containerd systemd unit file
- Adds installation scripts needed to generated CRI+CNI release tarball
- Update Github action release script to generate CRI+CNI release tarball
|
Build succeeded.
|
Member
|
Looks good! I guess we need to modify the |
|
Build succeeded.
|
dmcgowan
force-pushed
the
github-release-cri
branch
3 times, most recently
from
7d7883f to
014c251
Compare
|
Build succeeded.
|
dmcgowan
force-pushed
the
github-release-cri
branch
2 times, most recently
from
ffd6480 to
8c521c7
Compare
|
Build succeeded.
|
Member
|
59 commits wow! :) |
There was a problem hiding this comment.
Should there be a type=notify here? For other clouds except for GCE I see that original containerd.service from repo-root has been installed. For GCE, the change for notify type service is kept out. This might cause some systemd services dependent on containerd to start & fail before container runtime is up.
Member
Author
There was a problem hiding this comment.
This version was migrated over from CRI repository. It was created and managed by GCE folks, so I'll leave it to them if they want to change it going forward.
dmcgowan
force-pushed
the
github-release-cri
branch
from
8c521c7 to
3ecc812
Compare
|
Build succeeded.
|
dmcgowan
force-pushed
the
github-release-cri
branch
from
3ecc812 to
1a9b8a3
Compare
|
Build succeeded.
|
dmcgowan
force-pushed
the
github-release-cri
branch
from
1a9b8a3 to
cd75b1a
Compare
|
Build succeeded.
|
AkihiroSuda
reviewed
Aug 11, 2020
estesp
approved these changes
Aug 11, 2020
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM
Hopefully we can merge after fixing the conflict and test this on the next RC
mikebrow
approved these changes
Aug 11, 2020
Member
mikebrow
left a comment
mikebrow
left a comment
There was a problem hiding this comment.
LGTM
Thanks Derek! I forgot about the cluster/gce contents in the cri tar balls.
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Expose environment variables in the GCE containerd configuration script for configuring an additional runtime handler. This unblocks E2E testing of custom runtime handlers. Signed-off-by: Tim Allclair <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Mike Brown <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Synchronizes unit file with CRI's version Signed-off-by: Derek McGowan <[email protected]>
Add installation scripts needed to generate CRI + CNI tar package on release. Update Github action release script to generate CRI release tarballs for Linux and Windows. Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
github-release-cri
branch
from
cd75b1a to
60fa35f
Compare
|
Build succeeded.
|
AkihiroSuda
approved these changes
Aug 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.