docker: split private token helper functions to reusable pkg#4445
Merged
dmcgowan merged 2 commits intocontainerd:masterfrom Aug 25, 2020
Merged
docker: split private token helper functions to reusable pkg#4445dmcgowan merged 2 commits intocontainerd:masterfrom
dmcgowan merged 2 commits intocontainerd:masterfrom
Conversation
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
auth-refactor
branch
from
ca52c86 to
957bcb3
Compare
|
Build succeeded.
|
AkihiroSuda
approved these changes
Aug 3, 2020
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
auth-refactor
branch
from
cd3e415 to
b5185ea
Compare
|
Build succeeded.
|
Member
Author
|
@AkihiroSuda Added another commit to return full token structs from functions. |
Member
|
ping @AkihiroSuda @dmcgowan PTAL |
Member
|
LGTM but @dmcgowan should check and merge this |
dmcgowan
approved these changes
Aug 25, 2020
Member
dmcgowan
left a comment
dmcgowan
left a comment
There was a problem hiding this comment.
LGTM
Although this might need some refactoring before it is finalized for 1.5. I don't know if it makes much sense to have the package users worry about endpoint fallback and oauth vs anonymous.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid custom implementations of
Authorizerto copy-paste a lot of utility functions.@AkihiroSuda
Signed-off-by: Tonis Tiigi [email protected]