[release/1.3 backport] snapshots/devmapper: suspend a device to avoid data corruption #4416
Merged
estesp merged 2 commits intocontainerd:release/1.3from Jul 28, 2020
Merged
[release/1.3 backport] snapshots/devmapper: suspend a device to avoid data corruption #4416estesp merged 2 commits intocontainerd:release/1.3from
estesp merged 2 commits intocontainerd:release/1.3from
Conversation
|
Build succeeded.
|
Member
Author
|
Regarding the CI failure, we need to merge #4361 first to fix |
added 2 commits
July 28, 2020 11:43
According to https://github.com/torvalds/linux/blob/v5.7/Documentation/admin-guide/device-mapper/thin-provisioning.rst#internal-snapshots; > If the origin device that you wish to snapshot is active, you > must suspend it before creating the snapshot to avoid corruption. However the devmapper snapshotter was not doing that. Signed-off-by: Kazuyoshi Kato <[email protected]>
The function is required for the back-ported commit (5189072f). Signed-off-by: Kazuyoshi Kato <[email protected]>
Member
Author
|
Rebased the branch against release/1.3. Hopefully this fixes the CI errors. |
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4374