snapshots/devmapper: suspend a device to avoid data corruption#4374
snapshots/devmapper: suspend a device to avoid data corruption#4374fuweid merged 1 commit intocontainerd:masterfrom
Conversation
|
Build succeeded.
|
mxpv
left a comment
mxpv
left a comment
There was a problem hiding this comment.
Generally the fix makes sense to me.
I have one minor doc related comment below.
LGTM once the CI is green.
|
Let me rebase this branch first. I think master was not passing CI checks before. |
|
Build succeeded.
|
|
@kzys can you please do comments in the code and update error messages. |
According to https://github.com/torvalds/linux/blob/v5.7/Documentation/admin-guide/device-mapper/thin-provisioning.rst#internal-snapshots; > If the origin device that you wish to snapshot is active, you > must suspend it before creating the snapshot to avoid corruption. However the devmapper snapshotter was not doing that. Signed-off-by: Kazuyoshi Kato <[email protected]>
|
Build succeeded.
|
|
Would you mind if I backport the change to 1.3.x? I need to add ResumeDevice in addition to though. |
sure |
|
LGTM |
|
|
||
| // The base device must be suspend before taking a snapshot to | ||
| // avoid corruption. | ||
| // https://github.com/torvalds/linux/blob/v5.7/Documentation/admin-guide/device-mapper/thin-provisioning.rst#internal-snapshots |
There was a problem hiding this comment.
does it only work for new kernel?
There was a problem hiding this comment.
No. I just picked the latest non-rc version, because pointing master might break in future.
There was a problem hiding this comment.
I can use 5.4 (the latest LTS). 4.19 (the previous LTS) doesn't work well since the URL is different.
4 participants
Hello containerd folks,
We have found this issue in our testing stack and the fix seems working so far. I still haven't reproduced the issue locally with containerd-stress though.
According to https://github.com/torvalds/linux/blob/c309b6f24222246c18a8b65d3950e6e755440865/Documentation/admin-guide/device-mapper/thin-provisioning.rst#internal-snapshots;
However the devmapper snapshotter is currently not doing that.
Signed-off-by: Kazuyoshi Kato [email protected]