Skip to content

fix panic in shim is not logged#4298

Closed
milkwine wants to merge 1 commit intocontainerd:masterfrom
milkwine:master
Closed

fix panic in shim is not logged#4298
milkwine wants to merge 1 commit intocontainerd:masterfrom
milkwine:master

Conversation

@milkwine
Copy link
Copy Markdown

@milkwine milkwine commented Jun 3, 2020

#4274

The daemon log will be:

...
DEBU[2020-06-03T14:48:54.204864142+08:00] event forwarded                               ns=default topic=/tasks/create type=containerd.events.TaskCreate
DEBU[2020-06-03T14:48:54.225318724+08:00] event forwarded                               ns=default topic=/tasks/start type=containerd.events.TaskStart
panic: test20200520

goroutine 7 [running]:
github.com/containerd/containerd/runtime/v2/shim.Run.func1()
	/home/zsy/.asdf/installs/golang/1.13.5/packages/src/github.com/containerd/containerd/runtime/v2/shim/shim.go:151 +0x47
created by github.com/containerd/containerd/runtime/v2/shim.Run
	/home/zsy/.asdf/installs/golang/1.13.5/packages/src/github.com/containerd/containerd/runtime/v2/shim/shim.go:149 +0x47
INFO[2020-06-03T14:48:56.998794944+08:00] shim disconnected                             id=foo
WARN[2020-06-03T14:48:56.998935894+08:00] cleaning up after shim disconnected           id=foo namespace=default
INFO[2020-06-03T14:48:56.998989197+08:00] cleaning up dead shim                        
...

This pr has changed project containerd/fifo in vendor directory, because dup2 need to pass fd as param which hold by struct fifo.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 3, 2020

Build succeeded.

@milkwine
Copy link
Copy Markdown
Author

milkwine commented Jun 3, 2020

Need to open a PR in containerd/fifo first if we want this.

@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Jun 15, 2020

Could you open fifo PR?

@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Jun 15, 2020

cc @tonistiigi

@jterry75
Copy link
Copy Markdown
Contributor

jterry75 commented Jun 15, 2020

@kevpar - Since it looks like this is going to be a fifo approach for windows, we will likely need the shim on Windows to re-log the panic.log file in the task's dir. This will need a follow up pr from the Windows side

@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Jun 22, 2020

ping @milkwine

@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Aug 31, 2020

@milkwine Are you still interested in this?

@mxpv mxpv mentioned this pull request Oct 19, 2020
Merged
mxpv added a commit to mxpv/containerd that referenced this pull request Oct 26, 2020
@mxpv
Fix panic in shim not logged
4da306e 
Fix containerd#4274
Carry containerd#4298

Signed-off-by: Maksym Pavlenko <[email protected]>
@mxpv mxpv mentioned this pull request Oct 26, 2020
Merged
@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Oct 26, 2020

Carried as #4657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@milkwine @AkihiroSuda @jterry75