[release/1.3] Enable GH Actions for release/1.3 branch#4280
Merged
Conversation
estesp
force-pushed
the
enable-actions-1.3
branch
3 times, most recently
from
May 21, 2020 14:39
18067cc to
3393d59
Compare
Configuration that matches the Travis setup for release/1.3. Backported test fix for golangci-lint check; synced timeout for lint with master. Signed-off-by: Phil Estes <[email protected]>
estesp
force-pushed
the
enable-actions-1.3
branch
from
May 21, 2020 14:57
3393d59 to
55b88c4
Compare
estesp
changed the title
This was added in 40d898a, but doesn't appear to be used. Signed-off-by: Sebastiaan van Stijn <[email protected]> Signed-off-by: Phil Estes <[email protected]>
Unlike master, release/1.3 still has the socat dependency from CRI. Signed-off-by: Phil Estes <[email protected]>
estesp
force-pushed
the
enable-actions-1.3
branch
from
May 21, 2020 16:15
2e7282c to
c77ae0e
Compare
Member
|
Travis will be disabled in follow up? |
AkihiroSuda
approved these changes
May 21, 2020
This was referenced Jun 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configuration that matches the Travis setup for release/1.3.
Copied script changes from master for actions; lint fix in resolver test and updated to golangci-lint version from master, as well as matched 3m timeout for linting from master.
Cherry picked 4756258 from master to fix lint issue on Windows (unused var).
Signed-off-by: Phil Estes [email protected]