Add article to pull access denied error message#4248
Add article to pull access denied error message#4248glensc wants to merge 1 commit intocontainerd:masterfrom
Conversation
Signed-off-by: Elan Ruusamäe <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4248 +/- ##
=======================================
Coverage 38.34% 38.34%
=======================================
Files 90 90
Lines 12728 12728
=======================================
Hits 4881 4881
Misses 7181 7181
Partials 666 666
Continue to review full report at Codecov.
|
|
Build succeeded.
|
Zyqsempai
left a comment
There was a problem hiding this comment.
Sorry, but I think it doesn't make sense, to "lint" codebase with grammarly, but anyway thank you for your effort.
|
I did not lint the codebase for spelling errors. How I come to this poor language style is described in issue body. If I did lint the codebase, there would be a lot more matches, I'm sure of that. |
|
I'm tempted to not argue about a "the", but given you mention "poor language style" I have to say that error messages have, in most environments that I use, chosen brevity over grammar. For example, "file not found" is a very common filesystem error that we've all come to know and accept for decades, but really, if we're going to get pedantic should be: "the file is not found". "No such directory"? Shouldn't that be "there is no such directory found."? I feel like this is opening a can of worms that would mean a full revamping of error messages if we want to express all errors in completely correct grammar. I understand you are potentially not suggesting that, but if "grammarly" is the guide, then I assume most of our errors (and most errors in OS layer, libraries, etc.) will also not meet the requirements of "good grammar." |
This is why we don't make non-functional or changes which don't correct the statement. Having an error message searchable is often more valuable than it being grammatically correct. We bias toward error messages being short as long as they remain unambiguous. Non clarifying grammar articles are often on the chopping block there. |
The spelling fix was suggested to me by Grammarly when I pasted such error in our internal issue tracker.