Skip to content

Add article to pull access denied error message#4248

Closed
glensc wants to merge 1 commit intocontainerd:masterfrom
glensc:patch-1
Closed

Add article to pull access denied error message#4248
glensc wants to merge 1 commit intocontainerd:masterfrom
glensc:patch-1

Conversation

@glensc
Copy link
Copy Markdown

@glensc glensc commented May 12, 2020

The spelling fix was suggested to me by Grammarly when I pasted such error in our internal issue tracker.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #4248 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4248   +/-   ##
=======================================
  Coverage   38.34%   38.34%           
=======================================
  Files          90       90           
  Lines       12728    12728           
=======================================
  Hits         4881     4881           
  Misses       7181     7181           
  Partials      666      666           
Flag Coverage Δ
#windows 38.34% <100.00%> (ø)
Impacted Files Coverage Δ
remotes/docker/resolver.go 56.25% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0498503...dcdc7c7. Read the comment docs.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented May 12, 2020

Build succeeded.

Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I think it doesn't make sense, to "lint" codebase with grammarly, but anyway thank you for your effort.

@glensc
Copy link
Copy Markdown
Author

glensc commented May 14, 2020

I did not lint the codebase for spelling errors. How I come to this poor language style is described in issue body.

If I did lint the codebase, there would be a lot more matches, I'm sure of that.

@estesp
Copy link
Copy Markdown
Member

estesp commented May 14, 2020

I'm tempted to not argue about a "the", but given you mention "poor language style" I have to say that error messages have, in most environments that I use, chosen brevity over grammar. For example, "file not found" is a very common filesystem error that we've all come to know and accept for decades, but really, if we're going to get pedantic should be: "the file is not found". "No such directory"? Shouldn't that be "there is no such directory found."?

I feel like this is opening a can of worms that would mean a full revamping of error messages if we want to express all errors in completely correct grammar. I understand you are potentially not suggesting that, but if "grammarly" is the guide, then I assume most of our errors (and most errors in OS layer, libraries, etc.) will also not meet the requirements of "good grammar."

@dmcgowan
Copy link
Copy Markdown
Member

pasted such error in our internal issue tracker

This is why we don't make non-functional or changes which don't correct the statement. Having an error message searchable is often more valuable than it being grammatically correct. We bias toward error messages being short as long as they remain unambiguous. Non clarifying grammar articles are often on the chopping block there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants