Skip to content

.zuul: update go version to 1.13.10#4199

Merged
estesp merged 2 commits intocontainerd:masterfrom
fuweid:update-go-version-zuul
Apr 23, 2020
Merged

.zuul: update go version to 1.13.10#4199
estesp merged 2 commits intocontainerd:masterfrom
fuweid:update-go-version-zuul

Conversation

@fuweid
Copy link
Copy Markdown
Member

@fuweid fuweid commented Apr 20, 2020 •
edited
Loading

  • update go version for aarch64 testing
  • fix flaky test case
    • TestRuntimeWithEmptyMaxEnvProcs should restore the GoMaxProcs after
      test so that the temporary change of GoMaxProcs will not impact other
      case, like TestRuntimeWithNonEmptyMaxEnvProcs.

Signed-off-by: Wei Fu [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 20, 2020

Build succeeded.

@fuweid fuweid force-pushed the update-go-version-zuul branch from e330ecb to 0dfc994 Compare April 20, 2020 16:21
@estesp
Copy link
Copy Markdown
Member

estesp commented Apr 20, 2020

Hmm..

2020-04-20 16:17:56.318097 | The error appears to have been in '/var/lib/zuul/builds/dd5217ce777b41bb9fcf1456cdd12c72/untrusted/project_0/github.com/containerd/containerd/.zuul/playbooks/containerd-build/run.yaml': line 5, column 19, but may
2020-04-20 16:17:56.318113 | be elsewhere in the file depending on the exact syntax problem.
2020-04-20 16:17:56.318126 | 
2020-04-20 16:17:56.318137 | The offending line appears to be:
2020-04-20 16:17:56.318148 | 
2020-04-20 16:17:56.318159 |     - role: config-golang
2020-04-20 16:17:56.318170 |         go_version: '1.13.10'
2020-04-20 16:17:56.318181 |                   ^ here

@fuweid fuweid force-pushed the update-go-version-zuul branch from 0dfc994 to 11f5c55 Compare April 20, 2020 16:29
@dims
Copy link
Copy Markdown
Member

dims commented Apr 20, 2020

@fuweid too many whitespace change, are you sure? looked like there was a 4 char vs tab thing in the original PR which seemed to be the problem.

@estesp
Copy link
Copy Markdown
Member

estesp commented Apr 20, 2020

@dims it's working! just poked at the live log :)

@fuweid fuweid force-pushed the update-go-version-zuul branch from 11f5c55 to a9d95b3 Compare April 20, 2020 16:35
@dims
Copy link
Copy Markdown
Member

dims commented Apr 20, 2020

ah cool @estesp

@fuweid
Copy link
Copy Markdown
Member Author

fuweid commented Apr 20, 2020

@fuweid too many whitespace change, are you sure? looked like there was a 4 char vs tab thing in the original PR which seemed to be the problem.

@dims it seems the syntax should be like

# origin
tasks:
    - name: Build containerd

# it seems to be
tasks:
- name: Build containerd

I add one line go version command to show current go version. It can help when debug. :)

@dims
Copy link
Copy Markdown
Member

dims commented Apr 20, 2020

gotcha @fuweid

@fuweid
Copy link
Copy Markdown
Member Author

fuweid commented Apr 20, 2020

ok. go version is back to normal.

2020-04-20 16:39:24.967533 | ubuntu-xenial-arm64 | go version go1.13.10 linux/arm64

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 20, 2020

Build succeeded.

@fuweid
Copy link
Copy Markdown
Member Author

fuweid commented Apr 20, 2020 

020-04-20 16:43:11.646795 | ubuntu-xenial-arm64 | --- FAIL: TestRuntimeWithNonEmptyMaxEnvProcs (0.00s)
2020-04-20 16:43:11.647252 | ubuntu-xenial-arm64 |     shim_test.go:41: the max number CPU should be equal to available CPUs

hmm........

@fuweid fuweid changed the title .zuul: update go version to 1.13.10 [wip] .zuul: update go version to 1.13.10 Apr 20, 2020
@estesp
Copy link
Copy Markdown
Member

estesp commented Apr 20, 2020

This PR is good; might have a follow-on test issue with CPU awareness of host?

2020-04-20 16:43:11.646795 | ubuntu-xenial-arm64 | --- FAIL: TestRuntimeWithNonEmptyMaxEnvProcs (0.00s)
2020-04-20 16:43:11.647252 | ubuntu-xenial-arm64 |     shim_test.go:41: the max number CPU should be equal to available CPUs
2020-04-20 16:43:11.647377 | ubuntu-xenial-arm64 | FAIL

estesp
estesp approved these changes Apr 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Now that tests are running again we probably need a PR to fix the broken test on arm64

@fuweid
Copy link
Copy Markdown
Member Author

fuweid commented Apr 20, 2020

might have a follow-on test issue with CPU awareness of host?

OK! Thanks @estesp

@fuweid fuweid changed the title [wip] .zuul: update go version to 1.13.10 .zuul: update go version to 1.13.10 Apr 20, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 20, 2020 •
edited
Loading

Codecov Report

Merging #4199 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4199   +/-   ##
=======================================
  Coverage   38.34%   38.34%           
=======================================
  Files          90       90           
  Lines       12728    12728           
=======================================
  Hits         4881     4881           
  Misses       7181     7181           
  Partials      666      666
Flag Coverage Δ
#windows 38.34% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e094d36...9687ba6. Read the comment docs.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 22, 2020

Build succeeded.

@estesp
Copy link
Copy Markdown
Member

estesp commented Apr 22, 2020

CI broken; fix is #4206

fuweid added 2 commits April 23, 2020 22:09
@fuweid
.zuul: update go version to 1.13.10
b566859 
Signed-off-by: Wei Fu <[email protected]>
@fuweid
test: TestRuntimeWithEmptyMaxEnvProcs should cleanup
9687ba6 
TestRuntimeWithEmptyMaxEnvProcs should restore the GoMaxProcs after
test so that the temporary change of GoMaxProcs will not impact other
case, like TestRuntimeWithNonEmptyMaxEnvProcs.

Signed-off-by: Wei Fu <[email protected]>
@fuweid fuweid force-pushed the update-go-version-zuul branch from 3732ce1 to 9687ba6 Compare April 23, 2020 14:14
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 23, 2020

Build succeeded.

@fuweid
Copy link
Copy Markdown
Member Author

fuweid commented Apr 23, 2020

ok...openlab is green. but github actions fails 😂

@estesp
Copy link
Copy Markdown
Member

estesp commented Apr 23, 2020

All green now! :)

mikebrow
mikebrow approved these changes Apr 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 5d4a9ba into containerd:master Apr 23, 2020
@fuweid fuweid deleted the update-go-version-zuul branch April 24, 2020 07:48
@thaJeztah thaJeztah mentioned this pull request Aug 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fuweid @estesp @dims @codecov-io @mikebrow