Skip to content

Fix protobuild and CI check protos#4188

Merged
estesp merged 1 commit intocontainerd:masterfrom
estesp:fix-proto-gen
Apr 14, 2020
Merged

Fix protobuild and CI check protos#4188
estesp merged 1 commit intocontainerd:masterfrom
estesp:fix-proto-gen

Conversation

@estesp
Copy link
Copy Markdown
Member

@estesp estesp commented Apr 14, 2020

Signed-off-by: Phil Estes [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 14, 2020

Build succeeded.

@estesp estesp force-pushed the fix-proto-gen branch 2 times, most recently from 066a170 to 04a8846 Compare April 14, 2020 18:15
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #4188 into master will decrease coverage by 4.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4188      +/-   ##
==========================================
- Coverage   42.41%   38.39%   -4.02%     
==========================================
  Files         133       90      -43     
  Lines       15246    12726    -2520     
==========================================
- Hits         6466     4886    -1580     
+ Misses       7841     7176     -665     
+ Partials      939      664     -275     
Flag Coverage Δ
#linux ?
#windows 38.39% <ø> (+0.03%) ⬆️
Impacted Files Coverage Δ
archive/tar_opts.go 11.76% <0.00%> (-47.06%) ⬇️
cio/io.go 1.40% <0.00%> (-45.08%) ⬇️
snapshots/native/native.go 1.73% <0.00%> (-40.70%) ⬇️
archive/tar.go 18.95% <0.00%> (-29.64%) ⬇️
metadata/snapshot.go 33.18% <0.00%> (-14.40%) ⬇️
metadata/adaptors.go 39.04% <0.00%> (-9.53%) ⬇️
oci/spec_opts.go 32.50% <0.00%> (-2.25%) ⬇️
content/local/writer.go 57.69% <0.00%> (-0.97%) ⬇️
remotes/docker/config/hosts.go 43.13% <0.00%> (-0.66%) ⬇️
archive/tar_unix.go
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bd3bf9...04a8846. Read the comment docs.

@containerd containerd deleted a comment from theopenlab-ci Bot Apr 14, 2020
@containerd containerd deleted a comment from theopenlab-ci Bot Apr 14, 2020
@containerd containerd deleted a comment from theopenlab-ci Bot Apr 14, 2020
@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit ccaf35b into containerd:master Apr 14, 2020
@estesp estesp deleted the fix-proto-gen branch April 14, 2020 19:06
mxpv added a commit to mxpv/containerd that referenced this pull request Apr 14, 2020
Backport containerd#4188

Signed-off-by: Maksym Pavlenko <[email protected]>
@mxpv mxpv mentioned this pull request Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants