Skip to content

Revert "vendor: update go.etcd.io/bbolt v1.3.4"#4156

Merged
fuweid merged 1 commit intocontainerd:masterfrom
mxpv:bolt-revert
Apr 5, 2020
Merged

Revert "vendor: update go.etcd.io/bbolt v1.3.4"#4156
fuweid merged 1 commit intocontainerd:masterfrom
mxpv:bolt-revert

Conversation

@mxpv
Copy link
Copy Markdown
Member

@mxpv mxpv commented Apr 5, 2020

Revert bbolt update to 1.3.4 until better times.
#4154
etcd-io/bbolt#214

This reverts commit fb9e3d9.

Fixes: containerd#4154

Signed-off-by: Maksym Pavlenko <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 5, 2020

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 5, 2020

Codecov Report

Merging #4156 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4156      +/-   ##
==========================================
- Coverage   42.15%   42.14%   -0.01%     
==========================================
  Files         133      133              
  Lines       15209    15209              
==========================================
- Hits         6411     6410       -1     
- Misses       7868     7870       +2     
+ Partials      930      929       -1     
Flag Coverage Δ
#linux 45.46% <ø> (-0.01%) ⬇️
#windows 37.98% <ø> (ø)
Impacted Files Coverage Δ
snapshots/devmapper/pool_device.go 55.95% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a89fe1b...3968fb0. Read the comment docs.

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :(

@fuweid fuweid merged commit ba5a904 into containerd:master Apr 5, 2020
@mxpv mxpv deleted the bolt-revert branch April 5, 2020 23:40
@thaJeztah
Copy link
Copy Markdown
Member

reverts #4134

@thaJeztah
Copy link
Copy Markdown
Member

ping @dims FYI (for k8s)

@dims
Copy link
Copy Markdown
Member

dims commented Apr 6, 2020

thanks for the heads up @thaJeztah !

AkihiroSuda added a commit to AkihiroSuda/containerd that referenced this pull request Jun 22, 2020
We had once updated bbolt from v1.3.3 to v1.3.4 in containerd#4134,
but reverted to v1.3.3 in containerd#4156 due to "fatal error: sweep increased
allocation count" (etcd-io/bbolt#214).

The issue was fixed in bbolt v1.3.5 (etcd-io/bbolt#220).

Signed-off-by: Akihiro Suda <[email protected]>
fahedouch pushed a commit to fahedouch/containerd that referenced this pull request Aug 7, 2020
We had once updated bbolt from v1.3.3 to v1.3.4 in containerd#4134,
but reverted to v1.3.3 in containerd#4156 due to "fatal error: sweep increased
allocation count" (etcd-io/bbolt#214).

The issue was fixed in bbolt v1.3.5 (etcd-io/bbolt#220).

Signed-off-by: Akihiro Suda <[email protected]>
tussennet pushed a commit to tussennet/containerd that referenced this pull request Sep 11, 2020
We had once updated bbolt from v1.3.3 to v1.3.4 in containerd#4134,
but reverted to v1.3.3 in containerd#4156 due to "fatal error: sweep increased
allocation count" (etcd-io/bbolt#214).

The issue was fixed in bbolt v1.3.5 (etcd-io/bbolt#220).

Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda added a commit to AkihiroSuda/containerd that referenced this pull request Nov 10, 2020
We had once updated bbolt from v1.3.3 to v1.3.4 in containerd#4134,
but reverted to v1.3.3 in containerd#4156 due to "fatal error: sweep increased
allocation count" (etcd-io/bbolt#214).

The issue was fixed in bbolt v1.3.5 (etcd-io/bbolt#220).

Signed-off-by: Akihiro Suda <[email protected]>
(cherry picked from commit bebfbab)
Signed-off-by: Akihiro Suda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants