man: move ctr.1 and containerd-config to section 8#4140
man: move ctr.1 and containerd-config to section 8#4140estesp merged 1 commit intocontainerd:masterfrom
Conversation
|
Build succeeded.
|
There was a problem hiding this comment.
containerd-config should be moved as well?
There was a problem hiding this comment.
good one; I guess it's related to the containerd command, so would also be "admin" and/or require root? I can update
thaJeztah
changed the title
|
@AkihiroSuda updated |
|
Build succeeded.
|
|
Arf. don't merge yet; looks like generating the man-pages is hard-coded to append a |
I missed this in my previous change: the ctr man page is also in Section 8, because it's considered an administrative tool, and containerd-config is related to containerd so updating these as well. This commit also fixes naming of the generated files, which was hard-coded to .1. Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
Updated; PTAL |
|
Build succeeded.
|
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM; good catch on the code changes for the hardcoded ".1" :)
Codecov Report
@@ Coverage Diff @@
## master #4140 +/- ##
=======================================
Coverage 42.14% 42.14%
=======================================
Files 133 133
Lines 15209 15209
=======================================
Hits 6410 6410
Misses 7870 7870
Partials 929 929
Continue to review full report at Codecov.
|
heh, yes, I didn't notice it initially, because when building |
5 participants
I missed this in my previous change: the ctr man page is also in Section 8, because it's considered an administrative tool, and containerd-config is related to containerd so updating these as well.