[release/1.2] when kill a container check if it has been deleted#4121
Merged
crosbymichael merged 1 commit intocontainerd:release/1.2from Apr 1, 2020
Merged
Conversation
Member
|
Could you please sign off your commits (try |
Signed-off-by: payall4u <[email protected]>
payall4u
force-pushed
the
hotfix-delete-container-error
branch
from
672d499 to
f8be3cf
Compare
Contributor
Author
@mxpv |
Member
|
LGTM |
fuweid
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #4020 . When use cri-containerd and k8s, pod may be stuck in terminating. It happens when container is delete by runc, however containerd unawares of this or deletes container failed. When cri retry to delete container it will got a runc error
container <cid> does not exist. This is because cri ignore IsNotFound error, but shim is not converting the runc error to a containerd NotFound error.