[release/1.3 backport] Update cgroups#4105
Closed
dims wants to merge 4 commits intocontainerd:release/1.3from
Closed
[release/1.3 backport] Update cgroups#4105dims wants to merge 4 commits intocontainerd:release/1.3from
dims wants to merge 4 commits intocontainerd:release/1.3from
Conversation
Same as e1221e6 Note: now vndr >= v0.10 is required (containerd/cgroups#139) Signed-off-by: Davanum Srinivas <[email protected]>
Signed-off-by: Davanum Srinivas <[email protected]>
AkihiroSuda
approved these changes
Mar 12, 2020
Member
|
relates to / fixes #3951 |
|
Build succeeded.
|
Member
|
@thaJeztah 1.3 doesn't support v2 |
AkihiroSuda
reviewed
Mar 12, 2020
|
Build succeeded.
|
changes from 8ff5827 Signed-off-by: Davanum Srinivas <[email protected]>
AkihiroSuda
approved these changes
Mar 12, 2020
Member
Please consider using |
|
Build succeeded.
|
Member
Author
|
ugh, bad circular dependency! @thaJeztah @AkihiroSuda what do we do? |
Member
|
You can temporarily vendor your own fork of cri |
Member
whoops, my bad; copied the "fixes" from the original PR without clicking through to see the issue description |
Signed-off-by: Davanum Srinivas <[email protected]>
|
Build succeeded.
|
AkihiroSuda
approved these changes
Mar 12, 2020
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as e1221e6 originally filed by @AkihiroSuda