Skip to content

Support NOTIFY_SOCKET#4088

Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom
mxpv:sd
Mar 8, 2020
Merged

Support NOTIFY_SOCKET#4088
AkihiroSuda merged 1 commit intocontainerd:masterfrom
mxpv:sd

Conversation

@mxpv
Copy link
Copy Markdown
Member

@mxpv mxpv commented Mar 6, 2020

#4043

Signed-off-by: Maksym Pavlenko [email protected]

@mxpv mxpv changed the title Support NOTIFY_SOCKET #4043 Support NOTIFY_SOCKET Mar 6, 2020
@containerd containerd deleted a comment from theopenlab-ci Bot Mar 6, 2020
@containerd containerd deleted a comment from theopenlab-ci Bot Mar 6, 2020
@containerd containerd deleted a comment from theopenlab-ci Bot Mar 6, 2020
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 6, 2020

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 6, 2020

Codecov Report

Merging #4088 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4088   +/-   ##
=======================================
  Coverage   42.53%   42.53%           
=======================================
  Files         130      130           
  Lines       14828    14828           
=======================================
  Hits         6307     6307           
  Misses       7602     7602           
  Partials      919      919
Flag Coverage Δ
#linux 45.89% <ø> (ø) ⬆️
#windows 38.22% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3868dd7...ddae905. Read the comment docs.

@AkihiroSuda
Copy link
Copy Markdown
Member

LGTM

nit: can you squash commits?

Signed-off-by: Maksym Pavlenko <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Mar 7, 2020

Build succeeded.

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AkihiroSuda AkihiroSuda merged commit 92cfc5b into containerd:master Mar 8, 2020
@mxpv mxpv deleted the sd branch March 8, 2020 19:06
@akutz
Copy link
Copy Markdown

akutz commented Mar 12, 2020

Hi @mxpv,

Do you happen to know when the next ContainerD release will occur? I noticed the most recent one is only 23 days ago, but the Kubernetes machine images built from image-builder are having race bugs due to the start order of cloud-init and containerd. We put all of the right Wants/After/etc. statements in place, but it turns out that the race still occurs (kubernetes-sigs/image-builder#173) because of the lack of sd_notify in containerd. Since this issue was fixed in this PR, we could really use a new version of ContainerD with the patch. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants