Skip to content

vendor: update gotest.tools v3.0.2 #4072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
estesp merged 1 commit into from
Feb 28, 2020
Merged

vendor: update gotest.tools v3.0.2 #4072

estesp merged 1 commit into from
Feb 28, 2020

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Feb 28, 2020

Zyqsempai
Zyqsempai approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah mentioned this pull request Feb 28, 2020
Merged
@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 28, 2020

Build succeeded.

@thaJeztah
Copy link
Member Author

thaJeztah commented Feb 28, 2020

oops, forgot that vndr doesn't remove these old files;

These files were modified:

 D vendor/gotest.tools/LICENSE
 D vendor/gotest.tools/README.md
 D vendor/gotest.tools/go.mod

updating

@thaJeztah thaJeztah force-pushed the update_gotest_tools_v3 branch from 28d2cdd to f2edc6f Compare February 28, 2020 16:47
@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 28, 2020

Build succeeded.

cpuguy83
cpuguy83 approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Feb 28, 2020

Codecov Report

Merging #4072 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4072   +/-   ##
=======================================
  Coverage   42.66%   42.66%           
=======================================
  Files         130      130           
  Lines       14783    14783           
=======================================
  Hits         6307     6307           
  Misses       7557     7557           
  Partials      919      919
Flag Coverage Δ
#linux 46.05% <ø> (ø) ⬆️
#windows 38.25% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d24281...f2edc6f. Read the comment docs.

estesp
estesp approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 269015e into containerd:master Feb 28, 2020
@thaJeztah thaJeztah deleted the update_gotest_tools_v3 branch February 28, 2020 18:00
@dmcgowan dmcgowan mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@estesp estesp estesp approved these changes

+1 more reviewer

@Zyqsempai Zyqsempai Zyqsempai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thaJeztah @codecov-io @cpuguy83 @estesp @Zyqsempai