Skip to content

fix killall when use pidnamespace#4063

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
tedyu:namespace-path
Feb 27, 2020
Merged

fix killall when use pidnamespace#4063
dmcgowan merged 1 commit intocontainerd:masterfrom
tedyu:namespace-path

Conversation

@tedyu
Copy link
Copy Markdown
Contributor

@tedyu tedyu commented Feb 27, 2020

This PR applies the same change from #3149 to runtime/v2/runc/v1/service.go

@tedyu
Copy link
Copy Markdown
Contributor Author

tedyu commented Feb 27, 2020

/cc @fuweid

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 27, 2020

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 27, 2020

Codecov Report

Merging #4063 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4063   +/-   ##
=======================================
  Coverage   42.67%   42.67%           
=======================================
  Files         130      130           
  Lines       14778    14778           
=======================================
  Hits         6307     6307           
  Misses       7552     7552           
  Partials      919      919
Flag Coverage Δ
#linux 46.07% <ø> (ø) ⬆️
#windows 38.26% <ø> (ø) ⬆️
Impacted Files Coverage Δ
runtime/v2/shim/util_unix.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b4967b...4105135. Read the comment docs.

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 06b2840 into containerd:master Feb 27, 2020
@thaJeztah
Copy link
Copy Markdown
Member

I'll cherry-pick this one, given that this is a follow-up to #3149, which is in the 1.3 release, and was backported to the 1.2 release (#3274)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants