bugfix: cleanup dangling shim by brand new context#4048
Merged
estesp merged 1 commit intocontainerd:masterfrom Feb 24, 2020
Merged
bugfix: cleanup dangling shim by brand new context#4048estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
|
Build succeeded.
|
When there is timeout or cancel for create container, killShim will fail because of canceled context. The shim will be dangling and unmanageable. Need to use new context to do cleanup. Signed-off-by: Wei Fu <[email protected]>
fuweid
force-pushed
the
me-use-new-ctx-to-cleanup
branch
from
cf77e7e to
18e581d
Compare
|
Build succeeded.
|
Member
Author
|
the flaky case is caused by using two same image in different cases. will file pr to fix it. |
Member
Author
|
failed case is |
cpuguy83
approved these changes
Feb 21, 2020
Member
cpuguy83
left a comment
cpuguy83
left a comment
There was a problem hiding this comment.
LGTM
It could check if the error is a context cancell/deadline but this runs the risk of being racey anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is timeout or cancel for create container, killShim will fail
because of canceled context. The shim will be dangling and unmanageable.
Need to use new context to do cleanup.
Signed-off-by: Wei Fu [email protected]