[release/1.2] vendor: bump containerd/cri b1052f3b73fb9f0a6805d3c20e884a4cef265a38#3996
Conversation
…84a4cef265a38 full diff: containerd/cri@b075cc4...b1052f3 - containerd/cri#1389 pick up fix for CVE-2019-19921 in opencontainers/selinux - containerd/cri#1392 [release/1.2] Sync vendors with containerd 1.2.11 Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
hold on; forgot to stage the new vendor ( |
thaJeztah
force-pushed
the
1.2_bump_containerd_cri
branch
from
21bdb83 to
9456116
Compare
|
Actually weird; it looks to be needed because https://github.com/containerd/containerd/blame/a558638ee7a6e88bcea56c2f4421d6e95d6e1c1b/vendor/golang.org/x/oauth2/client_appengine.go#L16 uses it, but that was vendored 17 months ago |
Codecov Report
@@ Coverage Diff @@
## release/1.2 #3996 +/- ##
============================================
Coverage 44.19% 44.19%
============================================
Files 100 100
Lines 10847 10847
============================================
Hits 4794 4794
Misses 5313 5313
Partials 740 740
Continue to review full report at Codecov.
|
| golang.org/x/crypto 69ecbb4d6d5dab05e49161c6e77ea40a030884e1 | ||
| golang.org/x/oauth2 a6bd8cefa1811bd24b86f8902872e4e8225f74c4 | ||
| golang.org/x/time f51c12702a4d776e4c1fa9b0fabab841babae631 | ||
| google.golang.org/appengine 54a98f90d1c46b7731eb8fb305d2a321c30ef610 # v1.5.0 |
There was a problem hiding this comment.
ok, so it looks to build fine without this dependency
probably because the file has a // +build appengine build-tag (which is not set in our case)
@estesp @Random-Liu wdyt? should we keep it, or remove it?
There was a problem hiding this comment.
Would vndr bring this back in the future if we remove it?
If yes, I think it might be fine to leave it here. :)
|
LGTM |
1 similar comment
|
LGTM |
6 participants
full diff: containerd/cri@b075cc4...b1052f3
No local changesnew dependency needed unfortunately