[release/1.3 backport] platforms: fill default arm variant when parse platform specifier#3945
Merged
dmcgowan merged 1 commit intocontainerd:release/1.3from Jan 8, 2020
Merged
Conversation
arm has been supported, but something is missing, causes test failure
--- FAIL: TestParseSelector/linux (0.00s)
platforms_test.go:292: arm support not fully implemented: not implemented
--- FAIL: TestParseSelector/macOS (0.00s)
platforms_test.go:292: arm support not fully implemented: not implemented
Signed-off-by: Shengjing Zhu <[email protected]>
(cherry picked from commit 90cd777)
Signed-off-by: Shengjing Zhu <[email protected]>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## release/1.3 #3945 +/- ##
===============================================
+ Coverage 42.07% 42.07% +<.01%
===============================================
Files 129 129
Lines 14322 14321 -1
===============================================
Hits 6026 6026
+ Misses 7395 7394 -1
Partials 901 901
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #3939