Skip to content

ci: set pipefail in zuul script#3944

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
zhsj:fix-openlabci
Jan 8, 2020
Merged

ci: set pipefail in zuul script#3944
crosbymichael merged 1 commit intocontainerd:masterfrom
zhsj:fix-openlabci

Conversation

@zhsj
Copy link
Copy Markdown
Contributor

@zhsj zhsj commented Jan 8, 2020

Otherwise the exit code is always 0.

Fixes: #3943

Otherwise the exit code is always 0

Signed-off-by: Shengjing Zhu <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jan 8, 2020

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 8, 2020

Codecov Report

Merging #3944 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3944      +/-   ##
=========================================
- Coverage   42.41%   42.4%   -0.02%     
=========================================
  Files         130     130              
  Lines       14738   14738              
=========================================
- Hits         6251    6249       -2     
- Misses       7567    7568       +1     
- Partials      920     921       +1
Flag Coverage Δ
#linux 45.77% <ø> (-0.02%) ⬇️
#windows 37.94% <ø> (ø) ⬆️
Impacted Files Coverage Δ
snapshots/btrfs/btrfs.go 57.39% <0%> (-0.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d276ec...f3090ce. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 8b3ef5f into containerd:master Jan 8, 2020
@zhsj zhsj deleted the fix-openlabci branch January 8, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

openlab ci is broken

4 participants