[release/1.3 backport] Move flag.Parse in tests to TestMain#3926
Merged
estesp merged 1 commit intocontainerd:release/1.3from Jan 4, 2020
Merged
[release/1.3 backport] Move flag.Parse in tests to TestMain#3926estesp merged 1 commit intocontainerd:release/1.3from
estesp merged 1 commit intocontainerd:release/1.3from
Conversation
This this fixes issues with custom and testing flags in Go 1.3 and should work in previous go versions. Signed-off-by: Michael Crosby <[email protected]> (cherry pick from commit d5b7bf5) Signed-off-by: Shengjing Zhu <[email protected]>
|
Build succeeded.
|
AkihiroSuda
approved these changes
Jan 3, 2020
Codecov Report
@@ Coverage Diff @@
## release/1.3 #3926 +/- ##
============================================
Coverage 42.07% 42.07%
============================================
Files 129 129
Lines 14322 14322
============================================
Hits 6026 6026
Misses 7395 7395
Partials 901 901
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #3744, for some reasons, I need to build with go1.13..