Skip to content

[release/1.2 backport] Update Golang 1.12.14#3918

Merged
mxpv merged 1 commit intocontainerd:release/1.2from
thaJeztah:1.2_bump_golang_1.12.14
Dec 24, 2019
Merged

[release/1.2 backport] Update Golang 1.12.14#3918
mxpv merged 1 commit intocontainerd:release/1.2from
thaJeztah:1.2_bump_golang_1.12.14

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

backport of #3917 for the release/1.2 branch

go1.12.14 (released 2019/12/04) includes a fix to the runtime. See the Go 1.12.14
milestone on our issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.12.14+label%3ACherryPickApproved

Signed-off-by: Sebastiaan van Stijn [email protected]
(cherry picked from commit f4824d5)
Signed-off-by: Sebastiaan van Stijn [email protected]

go1.12.14 (released 2019/12/04) includes a fix to the runtime. See the Go 1.12.14
milestone on our issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.12.14+label%3ACherryPickApproved

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit f4824d5)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3918 into release/1.2 will decrease coverage by 3.67%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.2    #3918      +/-   ##
===============================================
- Coverage        47.87%   44.19%   -3.68%     
===============================================
  Files               91      100       +9     
  Lines             8483    10847    +2364     
===============================================
+ Hits              4061     4794     +733     
- Misses            3688     5313    +1625     
- Partials           734      740       +6
Flag Coverage Δ
#linux 47.87% <ø> (ø) ⬆️
#windows 41% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.3% <0%> (-10%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/tar.go 44.08% <0%> (-7.32%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 58.65% <0%> (-5.55%) ⬇️
content/local/store.go 48.51% <0%> (-5.03%) ⬇️
metadata/images.go 57.57% <0%> (-4.99%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
metadata/buckets.go 56.33% <0%> (-4.6%) ⬇️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b584375...e7b06ba. Read the comment docs.

Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxpv mxpv merged commit 28d1627 into containerd:release/1.2 Dec 24, 2019
@thaJeztah thaJeztah deleted the 1.2_bump_golang_1.12.14 branch December 24, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants