Skip to content

Update containerd/console vendor for fix#3906

Merged
mxpv merged 1 commit intocontainerd:masterfrom
estesp:update-console-vendor
Dec 20, 2019
Merged

Update containerd/console vendor for fix#3906
mxpv merged 1 commit intocontainerd:masterfrom
estesp:update-console-vendor

Conversation

@estesp
Copy link
Copy Markdown
Member

@estesp estesp commented Dec 20, 2019

Bring fix into master for containerd/console#34

Signed-off-by: Phil Estes [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Dec 20, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3906 into master will increase coverage by 3.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3906      +/-   ##
==========================================
+ Coverage   42.47%   45.86%   +3.39%     
==========================================
  Files         130      117      -13     
  Lines       14716    11786    -2930     
==========================================
- Hits         6251     5406     -845     
+ Misses       7544     5460    -2084     
+ Partials      921      920       -1
Flag Coverage Δ
#linux 45.86% <ø> (ø) ⬆️
#windows ?
Impacted Files Coverage Δ
remotes/docker/fetcher.go 54.11% <0%> (-5.41%) ⬇️
remotes/docker/auth.go 63.82% <0%> (-3.97%) ⬇️
remotes/docker/status.go 21.42% <0%> (-3.58%) ⬇️
remotes/docker/errdesc.go 28.12% <0%> (-2.65%) ⬇️
remotes/docker/errcode.go 47.61% <0%> (-1.6%) ⬇️
platforms/cpuinfo.go 3.77% <0%> (-0.85%) ⬇️
remotes/docker/handler.go 22.38% <0%> (-0.09%) ⬇️
errdefs/grpc.go 77.46% <0%> (-0.04%) ⬇️
remotes/docker/pusher.go 0% <0%> (ø) ⬆️
content/local/locks.go 100% <0%> (ø) ⬆️
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1809231...496836c. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants